Dependency resolution #3811
Draft
Dependency resolution #3811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto block-exporter-initial
…nto dependency-resolution
ma2bd
reviewed
Apr 22, 2025
| #[derive(Debug, Serialize, Deserialize, Clone)] | ||
| pub(super) struct Block { | ||
| pub(super) dependencies: DependencySet, | ||
| pub(super) destinatons: BTreeSet<DestinationId>, |
There was a problem hiding this comment.
typo: destinatons (same below)
ma2bd
reviewed
Apr 22, 2025
| synchronized_blocks: HashSet::new(), | ||
| synchronized_blobs: HashSet::new(), | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: Just derive Default and use it
ma2bd
reviewed
Apr 22, 2025
| guard | ||
| .save() | ||
| .await | ||
| .map_err(|e| Status::from_error(e.into()))?; | ||
| } | ||
| batch | ||
| }; | ||
|
|
||
| // after implementation of future destinations | ||
| // this will be offloaded to a seperate thread. |
ma2bd
reviewed
Apr 22, 2025
| type Batch = Batch; | ||
| type Error = ExporterError; | ||
|
|
||
| async fn read_batch(&self, keys: Vec<Self::Key>) -> Result<Self::Batch, Self::Error> { |
There was a problem hiding this comment.
seems like you may want to use read_confirmed_blocks and read_blobs (plural) here
ma2bd
reviewed
Apr 22, 2025
| /// The chain status, by chain ID. | ||
| state: ReentrantCollectionView<C, ChainId, ChainStatusView<C>>, | ||
| /// The block(and blob) index. | ||
| index: MapView<C, Key, Value>, |
There was a problem hiding this comment.
why mixing blocks and blobs vs using two maps?
ma2bd
reviewed
Apr 22, 2025
| } | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize, Clone)] | ||
| pub(super) struct Block { |
There was a problem hiding this comment.
Block, Blob, Batchare used in different parts of the codebase with a different meaning. Can we use something different, maybeExporterBlock, ExporterBlob, ExporterBatch if we don't have any better idea?
ma2bd
reviewed
Apr 22, 2025
| match result { | ||
| None => Ok(None), | ||
| Some(Value::Blob(blob)) => Ok(Some(blob)), | ||
| _ => Err(ViewError::InconsistentEntries), |
There was a problem hiding this comment.
see my question about the two maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since linera is a directed acyclic graph, a block may depend on any number of blocks ancestrally or in parallel. For a working block exporter a block must be exported along with its set of all dependencies.
Proposal
Dependency resolution for the linera-exporter.
The testing can be done in a more extensive, exhaustive and randomized manner. This will have to be revisited in the future.
The unit test module can also use some re-factorization, this can be done in a separate PR, along with the rest of the binary crate.
This PR will also successfully close #3666.
Test Plan
unit tests